fix: Wait for events to be flushed #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Nov 21, 2025
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Makes sense, I wonder tho why this/what changed compared to before
Member
|
Shouldn’t this be be resolved upstream in Sentry? |
Member
Author
You're totally right. I'll see why this is actually needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events which hold attributes such as
organization.slugormcp.*were not flushed correctly.sentry-mcp/packages/mcp-core/src/server.ts
Lines 281 to 286 in ce3ec0f
With this it will re-add these missing events, as it will wait with
waitUntilthat these events are flushed within the tool call.Example of a tool call event