fix(logs): merge global and per-log attributes #1486
Merged
+92
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keys get merged, and local values overwrite existing global values for the same key
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
tustanivsky
approved these changes
Jan 21, 2026
Collaborator
tustanivsky
left a comment
tustanivsky
left a comment
There was a problem hiding this comment.
Tested this fix locally in Unreal and now the attributes are merged as expected, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1485
This was an implementation bug, where we took global attributes but discarded them when any local attributes were present. Now, we merge these into one object, keeping the global attribute keys intact (unless the local attributes have the same key, in which case they will overwrite the value).