feat(options): read sample rates from env vars#1540
Merged
Conversation
Support SENTRY_SAMPLE_RATE and SENTRY_TRACES_SAMPLE_RATE environment variables during sentry_options_new(), using locale-independent parsing with validation. Values are clamped to [0.0, 1.0] by existing setters. https://develop.sentry.dev/sdk/expected-features/environment-variables#supported-environment-variables Closes: #1519 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Reject NaN values parsed from SENTRY_SAMPLE_RATE and SENTRY_TRACES_SAMPLE_RATE, as NaN bypasses the clamping logic in the setter functions. Also restore env vars after tests and add a NaN-specific test case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract parse_double_env helper to deduplicate sample rate env parsing and tolerate trailing whitespace. Replace SETENV/UNSETENV macros with pushenv/popenv functions that clone the old value before overwriting, preventing use of dangling getenv pointers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Replace isnan with !isfinite to also reject inf/-inf values, which would otherwise get clamped and silently enable full sampling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move env var double parsing from sentry_options.c into a reusable sentry__getenv_double(name, fallback) helper in sentry_utils. This simplifies option initialization to inline calls and moves parsing tests to test_utils.c where they test the utility directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mujacica
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
SENTRY_SAMPLE_RATEandSENTRY_TRACES_SAMPLE_RATEenvironment variables duringsentry_options_new(), using locale-independent parsing with validation. Values are clamped to [0.0, 1.0] by the existing setter functions.See also:
https://develop.sentry.dev/sdk/expected-features/environment-variables#supported-environment-variables
Closes: #1519