fix(native): Fix build-time warnings with C++ builds#1671
Merged
Conversation
86cfe24 to
a74499e
Compare
| // Populate OS version from uname(), matching Crashpad behavior | ||
| struct utsname uts; | ||
| char csd_version[256] = ""; | ||
| char csd_version[512] = ""; |
Member
There was a problem hiding this comment.
do we need the full 512 or is this a bit overkill (since we know it to be upper-bounded by 260, maybe we just take the next largest size divisible by 8)
Suggested change
| char csd_version[512] = ""; | |
| char csd_version[264] = ""; |
jpnurmi
approved these changes
Apr 27, 2026
a74499e to
3be9ced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summed size of
utsnamefields could be larger than the 256 bytes we allow for thecsd_versionstring. (see linux/sysname.h`). Thus we increase the size to fit these fields.