Skip to content

feat(path): add sentry__path_copy for large attachments#1680

Merged
jpnurmi merged 2 commits intomasterfrom
jpnurmi/feat/copy-file
Apr 28, 2026
Merged

feat(path): add sentry__path_copy for large attachments#1680
jpnurmi merged 2 commits intomasterfrom
jpnurmi/feat/copy-file

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented Apr 28, 2026

Normal attachments are safe after being embedded into the envelope during a crash. However, with the upcoming large attachments that are uploaded separately and not stored in the envelope to avoid ever reading large attachments into memory, we must make a copy of the large attachment to keep it safe. This PR adds an internal API for doing that.

  • Normal attachments: safely embedded into envelopes during crashes ✅
  • Large minidumps: safely written straight into the database directory ✅
  • Other large attachments: arbitrary external files that cannot be safely referenced across sessions -> must be copied to keep the data safe

Extracted from #1545

#skip-changelog (internal)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c93a070

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b6565df. Configure here.

Comment thread CMakeLists.txt
@jpnurmi jpnurmi merged commit de05686 into master Apr 28, 2026
60 checks passed
@jpnurmi jpnurmi deleted the jpnurmi/feat/copy-file branch April 28, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants