feat(native): TUS upload for large attachments#1684
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/feat/tus
branch
5 times, most recently
from
174dcb1 to
a54f799
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/native-tus
branch
2 times, most recently
from
58dd9b3 to
6948a9a
Compare
jpnurmi
commented
Apr 30, 2026
Comment on lines
-3013
to
-3015
| // Mark as done | ||
| SENTRY_DEBUG("Marking crash state as DONE"); | ||
| sentry__atomic_store(&ctx->state, SENTRY_CRASH_STATE_DONE); |
Collaborator
Author
There was a problem hiding this comment.
Moved to sentry__crash_daemon_main() after sentry__transport_shutdown() and sentry__transport_dump_queue(), to prevent DONE from being written before the daemon has either sent or dumped the crash envelope if it hit the shutdown timeout.
jpnurmi
force-pushed
the
jpnurmi/feat/native-tus
branch
from
6948a9a to
b45ff1b
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jpnurmi
changed the title
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a3b72c. Configure here.
mujacica
approved these changes
Apr 30, 2026
Preserve the large-attachment setting in the native crash context so the crash daemon can handle attachment placeholders after a crash. The daemon now skips inlining placeholder attachments, caches them as attachment-ref items, and lets the HTTP transport resolve those refs through the TUS upload flow. Keep the materialized crash envelope and cached attachment files available for restart retry when shutdown cannot finish the transport work. Clean the run only after a clean shutdown with no dumped envelopes, and mark the crash state as DONE after crash processing has reached daemon cleanup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: OpenAI Codex <noreply@openai.com>
Force native crash daemon run cleanup after a successful transport drain. Large crash attachments retain the run for shutdown persistence, but a successful send must remove it to avoid resending on the next startup. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Call the single-attachment cache helper from the native crash daemon after the attachment has already been checked as a placeholder. This avoids re-running the placeholder filter for a single temporary attachment. Co-Authored-By: OpenAI Codex <noreply@openai.com>
jpnurmi
force-pushed
the
jpnurmi/feat/native-tus
branch
from
f58ee3e to
3605d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #1545 with TUS/large-attachment support for the native daemon.
https://sentry-sdks.sentry.io/issues/7452013648/?project=4506178389999616
#skip-changelog (in #1545)