test: speed up client_report_concurrent with valgrind#1689
Merged
Conversation
The code-checker+valgrind CI job has gotten slow (sometimes > 1h): https://github.com/getsentry/sentry-native/actions/runs/25117272965 The slow down is caused by the client_report_concurrent stress test. The flush side of the test spins immediately when there is no client report to save, while the producer side repeatedly discards reports from multiple threads. Under Valgrind this can spend minutes in scheduler contention and make the stress test dominate the job. Yield in both hot loops, matching the approach used for the logs and metrics stress tests in bcd4633.
mujacica
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux (GCC 13.3.0 + code-checker + valgrind) CI job has become slow (sometimes > 1h): https://github.com/getsentry/sentry-native/actions/runs/25117272965
The slowdown is caused by the
client_report_concurrentstress test. The flush side of the test spins immediately when there is no client report to save, while the producer side repeatedly discards reports from multiple threads. Under Valgrind, this can spend minutes in scheduler contention.Yield in both hot loops, matching the approach used for the logs and metrics stress tests in bcd4633.