fix: Expose a method to clear the module cache#216
Conversation
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
going by the comment being removed it seems the default timeout is 1h. so i guess that still stops it from being completely stuck
yes. Originally, I added the timeout and the comment because I messed up the start script, which did basically nothing for an hour before being timed out. Now that the script at least does what it should, its rather a matter of how quick the CI machine running the job actually is. We have simulator starts in a minute, or 6 minutes, its very random. :-( |
| */ | ||
| SENTRY_API const char *sentry_options_get_http_proxy(sentry_options_t *opts); | ||
| SENTRY_API const char *sentry_options_get_http_proxy( | ||
| const sentry_options_t *opts); |
There was a problem hiding this comment.
Can you make such bug fixes in separate PRs? By looking at the git history, it gets easier to see changes and when writing the changelog we don't miss things (especially when someone else writes it).
There was a problem hiding this comment.
Sure. I was just mashing together a few oneliners in this PR to avoid the overhead ;-) But yes, that overhead actually serves a very good purpose.
3 participants
fixes #213
Also make
sentry_options_get_http_proxyconst-correct, fixes #214