feat(docs): Update onboard/add-option skill to include rust examples#80
Merged
hubertdeng123 merged 6 commits intomainfrom Mar 17, 2026
Merged
feat(docs): Update onboard/add-option skill to include rust examples#80hubertdeng123 merged 6 commits intomainfrom
hubertdeng123 merged 6 commits intomainfrom
Conversation
.claude/skills/add-option/SKILL.md
Outdated
| **Supported types:** `string`, `integer`, `number`, `boolean` | ||
|
|
||
| **Return types:** | ||
| - Python: `opts.get('key')` returns `str | int | float | bool` |
Member
There was a problem hiding this comment.
we will support lists too when the release is cut
.claude/skills/onboard/SKILL.md
Outdated
| opts = options('{namespace}') | ||
|
|
||
| # Read values (returns schema default if ConfigMap doesn't exist) | ||
| # Return types: str | int | float | bool |
Member
There was a problem hiding this comment.
ditto, just make sure to check for all these and include lists
kenzoengineer
requested changes
Mar 16, 2026
Member
kenzoengineer
left a comment
kenzoengineer
left a comment
There was a problem hiding this comment.
this PR has to be updated with all the new features:
- lists
- structs
- overrides
hubertdeng123
force-pushed
the
hubertdeng123/update-skills-rust
branch
from
e75b3bd to
5cc1519
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
kenzoengineer
approved these changes
Mar 16, 2026
Member
kenzoengineer
left a comment
kenzoengineer
left a comment
There was a problem hiding this comment.
lgtm assuming the option you used for the examples isn't something sensitive (this repo is public, but seer is internal)
Member
Author
|
def nothing internal here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.