Reproducible builds #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
reproducible-builds
branch
from
de1c737 to
22d4a31
Compare
Litarnus
approved these changes
Sep 22, 2025
Contributor
Litarnus
left a comment
Litarnus
left a comment
There was a problem hiding this comment.
LGTM!
I'm not sure if we really need a real version number since we only care about file changes but I guess it also doesn't hurt to have it
Collaborator
Author
|
Yeah I also started with just leaving it at 0.0.0 but I guess it could help if we need to debug and I believe we can show the version in the output... (tbd in another PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1, we should cleanup the timestamp and
COMPOSER_ROOT_VERSION. I've opted to not bother with the timestamp, and the version is only set when craft creates a release.In PRs and normal development we use 0.0.0 to get somewhat reproducible builds. We could use Docker to get builds that are also reproducible locally since it depends on the exact PHP version and some other environment things. But not sure we need to go that hard.