[1.x] PHP Fatal error: Uncaught ErrorException: Undefined index: function in /lib/Raven/Stacktrace.php:89

[TPETb]

Guess this is PHP7 problem

problem is with the code
'function' => $nextframe['function'],

$nextframe doesn't necessary contain function index, it can be for example

array (
  'file' => '/vagrant/dev/admin/vendor/composer/ClassLoader.php',
  'line' => 412,
  'include_filename' => '/vagrant/dev/admin/app/SaaS/Admin/Models/User.php',
  'args' => 
  array (
  ),
)

Addressing undefined index leads to error posted in subject.

[dcramer]

I dont know the greatest way we could write a test for this (which I'd love to have, to make sure we don't fuck it up in the future), but the attached commit should resolve it and is safe with our upstream API.

I'm wondering if this is only for use statements, or if its also include/require functions, and if we should mock a function call as well.

[pelmered]

I know it's an old issue, but I have the same issue on this line: https://github.com/getsentry/sentry-php/blob/master/src/Stacktrace.php#L119

[Jean85]

Feel free to write a PR to fix this issue too. Also, I would like to remind you that we have a 2.0 beta release which is near its stable release, you should try it.

[pelmered]

Sure, I'll submit a PR.
I'm already using 2.0.0-beta1. Is the master branch for 2.0 development?

[ste93cry]

Yes it is. I'm wondering in which case the function name isn't available in the frame though...

[Jean85]

Maybe if it's a closure/lambda?

[ste93cry]

I don't think so because the function key at the line that is crashing is used only if class is available too... By the way there is for sure some strange case, but the fix should be as simple as adding an isset($frame['function])` here:

sentry-php/src/Stacktrace.php

Line 118 in dee2230

if (isset($backtraceFrame['class'])) {

[Jean85]

@pelmered are you able to create a reproducing case? I would like to port the resulting test to the master branch in case.