[2.0] User Agent - Header - Browser

[HazAT]

TBH I am not sure if this isn't already fixed. I just want to make sure, that if possible we should not forget to provide as good as possible Browser Context for PHP events.
I guess this PR is somewhat related #690

tl;dr
We have to make sure Browser Context works correctly.

[ste93cry]

Neither 1.x nor 2.0 actually sends the browser context type along with the event data. Isn't this something more useful on client side SDKs like the Javascript one?

[HazAT]

If we are able to extract it from $_SERVER['request'] we should do it.

[ste93cry]

According to the documentation it's not clear if we have to pass the user agent or if we have to parse it into the name and version properties. Parsing the user agent is a difficult task in case

[Jean85]

First of all, are we sure that we want to conflate this in the 2.0 milestone? It's not a BC change, so we could postpone it to a 2.1 release.

Second, maybe we can rely on an external dep to parse it?

[ste93cry]

so we could postpone it to a 2.1 release

I think that the timeline allows us to do it even in 2.0 as it's a simple change (it should be only a new Context type)

Second, maybe we can rely on an external dep to parse it?

This is what I really want to avoid. A dependency to parse a user-agent server-side seems strange to me. I don't see a valid reason that a server-side application would need the browser to debug an error

[HazAT]

We only have to set the user-agent in the request context, parsing happens on the server.
https://github.com/getsentry/sentry-javascript/blob/65965ff30b4c978c4f200ef8bb5c88d220059324/packages/browser/src/integrations/useragent.ts

[Jean85]

We only have to set the user-agent in the request context, parsing happens on the server.

Oh great, so it's super easy!

[ste93cry]

The JS integration should puts the user agent into the HTTP request headers passed along with the request context. We already add all headers on our side, so it should already work... Can someone check this?

[HazAT]

I just checked it, we send the header but I think it's in the wrong place.
I will fix this now.

[ste93cry]

The problem is related to getsentry/sentry#8555 and from what I understand there is not yet a solution that avoid having to parse the user agent in each SDK to send the browser name and version separately in its own context

[HazAT]

@ste93cry Yeah, it's a server issue.

[HazAT]

ref: getsentry/sentry#10679