Skip to content

Conversation

@DeyV
Copy link
Contributor

@DeyV DeyV commented Jan 4, 2018

Thix Fix notice array_key_exists() expects parameter 2 to be array, null given

This fix should be added to 1.8 and 2.0 branches

…() expects parameter 2 to be array, null given
@Jean85
Copy link
Contributor

Jean85 commented Jan 4, 2018

The 2.x branch is already ok, it has a different flow with already multiple isset checks.

Thanks for spotting this BTW! Can you add a regression test where you pass an empty array as $frames?

@DeyV
Copy link
Contributor Author

DeyV commented Jan 5, 2018

The 2.x branch is already ok

Great

Can you add a regression test

of course

@Jean85 Jean85 merged commit b1d1d21 into getsentry:master Jan 7, 2018
Jean85 added a commit that referenced this pull request Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants