Skip to content

fix: Silence CS1701/CS1702 warnings from Add-Type on PowerShell Core #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −1
Open

fix: Silence CS1701/CS1702 warnings from Add-Type on PowerShell Core #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d826ff5
fix: Silence CS1701/CS1702 warnings from Add-Type on PowerShell Core
jamescrosswell May 22, 2026
7104bd6
fix: guard -CompilerOptions behind $PSEdition check for PS 5.1 compat
jamescrosswell May 22, 2026
5557f84
Add changelog entry
jamescrosswell May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Silence CS1701/CS1702 warnings emitted by `Add-Type` when importing the module on PowerShell hosts whose runtime `System.Runtime` version differs from the one `Sentry.dll` was compiled against ([#129](https://github.com/getsentry/sentry-powershell/pull/129))

## 0.4.0

### Fixes
Expand Down
11 changes: 10 additions & 1 deletion modules/Sentry/Sentry.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,16 @@ $moduleInfo = Import-PowerShellDataFile (Join-Path (Split-Path -Parent $MyInvoca
. "$privateDir/Get-SentryAssembliesDirectory.ps1"
$sentryDllPath = (Join-Path (Get-SentryAssembliesDirectory) 'Sentry.dll')

Add-Type -TypeDefinition (Get-Content "$privateDir/SentryEventProcessor.cs" -Raw) -ReferencedAssemblies $sentryDllPath -Debug:$false
$addTypeParams = @{
TypeDefinition = (Get-Content "$privateDir/SentryEventProcessor.cs" -Raw)
ReferencedAssemblies = $sentryDllPath
Debug = $false
}
# -CompilerOptions is PS Core only; suppress CS1701/CS1702 (harmless binding-redirect noise) when available.
if ($PSEdition -eq 'Core') {
$addTypeParams['CompilerOptions'] = '/nowarn:CS1701;CS1702'
}
Add-Type @addTypeParams
. "$privateDir/SentryEventProcessor.ps1"

Get-ChildItem $publicDir -Filter '*.ps1' | ForEach-Object {
Expand Down
Loading