feat(billing): Add endpoint for fetching orgs with usage#194
feat(billing): Add endpoint for fetching orgs with usage#194brendanhsentry merged 11 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
| repeated DataCategory categories = 3; | ||
| } | ||
|
|
||
| message GetOrgsWithUsageResponse { |
There was a problem hiding this comment.
this is going to return ALL active orgs, you probably don't want that
There was a problem hiding this comment.
should we add limit: int field or something to the request?
There was a problem hiding this comment.
I would add a limit and pagetoken to the request and a pagetoken to the response (which can just be an offset for now)
There was a problem hiding this comment.
ok i was following what i saw in other snuba endpoints and added the pagetoken to the request as well
| import "sentry_protos/billing/v1/data_category.proto"; | ||
|
|
||
| message PageToken { | ||
| uint64 offset = 1; |
There was a problem hiding this comment.
should be a oneof here such that it can be different things but not many things
There was a problem hiding this comment.
whoops i misunderstood earlier
2 participants
Will be used to fetch orgs that have sent usage between start and end time stamps.