ref: Convert GetUninvoicedContractsResponse to return contract_ids#213
Merged
noahsmartin merged 2 commits intomainfrom Apr 23, 2026
Merged
ref: Convert GetUninvoicedContractsResponse to return contract_ids#213noahsmartin merged 2 commits intomainfrom
noahsmartin merged 2 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
volokluev
approved these changes
Apr 23, 2026
brendanhsentry
approved these changes
Apr 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on the implementation of this I realized the caller will only need the contract ids because these will be the input to taskworker jobs that run for each contract. The job will then use the id to request the full contract from the contract service.