feat(billing): add tax_number to BillingDetails#286
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This was referenced Jun 4, 2026
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
c040360 to
d4052c4
Compare
dashed
changed the title
brendanhsentry
approved these changes
Jun 5, 2026
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
729d1fc to
42df697
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Adds an optional tax_number (e.g. VAT ID) to BillingDetails for determining a customer's tax treatment. Sales tax is no longer carried on the contract requests as a dedicated field; it now flows through line_items as a typed entry. The field slots that were considered for it are reserved on CreateContractRequest (7) and RolloverContractRequest (6). Regenerates the Rust bindings.
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
c407799 to
7ae8585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
optional string tax_number = 6toBillingDetails(the customer's tax registration number, e.g. VAT ID), used when determining tax treatment.Sales tax is no longer carried on the contract requests as a dedicated
sales_taxfield. It now flows throughline_itemsas a typedInvoiceLineItem(see the typed line-item change this PR is stacked on). The field slots previously considered forsales_taxare reserved for hygiene:CreateContractRequest:reserved 7;RolloverContractRequest:reserved 6;Changes
BillingDetails.tax_number = 6(new, optional string)CreateContractRequest:reserved 7;RolloverContractRequest:reserved 6;Rust bindings regenerated via
make build-rust; Python bindings viamake build-py(py/is gitignored).Stacking
main→ #293 (InvoiceLineItem.type) → this PR → #287 (tax_pending). Review/merge in order.Test plan
make build-py+make build-rustsucceedbuf lint/buf formatpass