ref(taskbroker) Add at_most_once flag to task activations #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tasks can be marked as being only executed at most once. Add a flag to denote that status. Tasks with this status are guaranteed to execute 0 or 1 times. The worker uses this flag to determine how it should handle the task.
markstory
approved these changes
Nov 25, 2024
evanh
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 26, 2024
If a task is marked as at_most_once, then check the cache to see if the task has already been seen before. If it has, assume the task has already been executed and continue. Otherwise store the task ID and execute the task. Depends on getsentry/sentry-protos#66 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Dec 2, 2024
If a task is marked as at_most_once, then check the cache to see if the task has already been seen before. If it has, assume the task has already been executed and continue. Otherwise store the task ID and execute the task. Depends on getsentry/sentry-protos#66 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tasks can be marked as being only executed at most once. Add a flag to denote that status.
Tasks with this status are guaranteed to execute 0 or 1 times. The worker uses this flag to
determine how it should handle the task.