Skip to content

fix: Selective disabling option for N+1 warnings#4888

Closed
Dibbu-cell wants to merge 2 commits intogetsentry:masterfrom
Dibbu-cell:change1
Closed

fix: Selective disabling option for N+1 warnings#4888
Dibbu-cell wants to merge 2 commits intogetsentry:masterfrom
Dibbu-cell:change1

Conversation

@Dibbu-cell
Copy link

Description

This PR introduces an opt-out mechanism for N+1 detection in the Python SDK so users can selectively mark code paths where N+1-style queries are intentionally acceptable.

Issues

Reminders

Hi! This PR is for Hacktoberfest. Please add the hacktoberfest-accepted label if it cannot be merged soon. Thank you!

@Dibbu-cell Dibbu-cell requested a review from a team as a code owner October 5, 2025 15:06
cursor[bot]

This comment was marked as outdated.

@Dibbu-cell Dibbu-cell changed the title Added Selective disabling option for N+1 warnings fix: Selective disabling option for N+1 warnings Oct 5, 2025
@sentrivana
Copy link
Contributor

Hi @Dibbu-cell, thanks for the PR but I'll be closing it:

  • we don't know if we're even going ahead with Selective disabling option for N+1 warnings #4887
  • the n+1 issue detection is happening on the server, so this would actually need sdk as well as sentry support
  • I don't think we should be adding a completely new mechanism to the sdk unless there's a really good reason

@sentrivana sentrivana closed this Oct 6, 2025
@Dibbu-cell
Copy link
Author

Please add the hacktoberfest-accepted label if it cannot be merged soon. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selective disabling option for N+1 warnings

2 participants