Skip to content

chore(metrics): Rename _metrics to metrics #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
+15 −14
Merged

chore(metrics): Rename _metrics to metrics #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c1048
chore(metrics): Rename _metrics to metrics
alexander-alderman-webb Oct 28, 2025
e344c17
tests
alexander-alderman-webb Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sentry_sdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from sentry_sdk import profiler
from sentry_sdk import metrics
from sentry_sdk.scope import Scope
from sentry_sdk.transport import Transport, HttpTransport
from sentry_sdk.client import Client
Expand Down Expand Up @@ -48,6 +49,7 @@
"trace",
"monitor",
"logger",
"metrics",
"profiler",
"start_session",
"end_session",
Expand Down
0 sentry_sdk/_metrics.py → sentry_sdk/metrics.py
View file
Open in desktop
File renamed without changes.
27 changes: 13 additions & 14 deletions tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import pytest

import sentry_sdk
from sentry_sdk import _metrics
from sentry_sdk import get_client
from sentry_sdk.envelope import Envelope
from sentry_sdk.types import Metric
Expand Down Expand Up @@ -39,9 +38,9 @@ def test_metrics_disabled_by_default(sentry_init, capture_envelopes):

envelopes = capture_envelopes()

_metrics.count("test.counter", 1)
_metrics.gauge("test.gauge", 42)
_metrics.distribution("test.distribution", 200)
sentry_sdk.metrics.count("test.counter", 1)
sentry_sdk.metrics.gauge("test.gauge", 42)
sentry_sdk.metrics.distribution("test.distribution", 200)

assert len(envelopes) == 0

Expand All @@ -50,9 +49,9 @@ def test_metrics_basics(sentry_init, capture_envelopes):
sentry_init(_experiments={"enable_metrics": True})
envelopes = capture_envelopes()

_metrics.count("test.counter", 1)
_metrics.gauge("test.gauge", 42, unit="millisecond")
_metrics.distribution("test.distribution", 200, unit="second")
sentry_sdk.metrics.count("test.counter", 1)
sentry_sdk.metrics.gauge("test.gauge", 42, unit="millisecond")
sentry_sdk.metrics.distribution("test.distribution", 200, unit="second")

get_client().flush()
metrics = envelopes_to_metrics(envelopes)
Expand Down Expand Up @@ -81,7 +80,7 @@ def test_metrics_experimental_option(sentry_init, capture_envelopes):
sentry_init(_experiments={"enable_metrics": True})
envelopes = capture_envelopes()

_metrics.count("test.counter", 5)
sentry_sdk.metrics.count("test.counter", 5)

get_client().flush()

Expand All @@ -99,7 +98,7 @@ def test_metrics_with_attributes(sentry_init, capture_envelopes):
)
envelopes = capture_envelopes()

_metrics.count(
sentry_sdk.metrics.count(
"test.counter", 1, attributes={"endpoint": "/api/test", "status": "success"}
)

Expand All @@ -121,7 +120,7 @@ def test_metrics_with_user(sentry_init, capture_envelopes):
sentry_sdk.set_user(
{"id": "user-123", "email": "test@example.com", "username": "testuser"}
)
_metrics.count("test.user.counter", 1)
sentry_sdk.metrics.count("test.user.counter", 1)

get_client().flush()

Expand All @@ -138,7 +137,7 @@ def test_metrics_with_span(sentry_init, capture_envelopes):
envelopes = capture_envelopes()

with sentry_sdk.start_transaction(op="test", name="test-span"):
_metrics.count("test.span.counter", 1)
sentry_sdk.metrics.count("test.span.counter", 1)

get_client().flush()

Expand All @@ -154,7 +153,7 @@ def test_metrics_tracing_without_performance(sentry_init, capture_envelopes):
sentry_init(_experiments={"enable_metrics": True})
envelopes = capture_envelopes()

_metrics.count("test.span.counter", 1)
sentry_sdk.metrics.count("test.span.counter", 1)

get_client().flush()

Expand Down Expand Up @@ -197,8 +196,8 @@ def _before_metric(record, hint):
)
envelopes = capture_envelopes()

_metrics.count("test.skip", 1)
_metrics.count("test.keep", 1)
sentry_sdk.metrics.count("test.skip", 1)
sentry_sdk.metrics.count("test.keep", 1)

get_client().flush()

Expand Down