fix(integrations): properly distinguish between network.transport and mcp.transport #5063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "mcp-session-id" | ||
| ): | ||
| # StreamableHTTP transport uses header | ||
| mcp_transport = "http" |
There was a problem hiding this comment.
Bug: Misclassified Requests Default to Stdio Transport Mode
The _get_request_context_data function defaults mcp_transport to "stdio" even when a request object is present. This misclassifies network-based HTTP requests as "stdio" if specific session ID indicators are absent.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5063 +/- ##
==========================================
- Coverage 83.94% 83.90% -0.05%
==========================================
Files 179 179
Lines 17904 17922 +18
Branches 3179 3188 +9
==========================================
+ Hits 15030 15037 +7
- Misses 1902 1910 +8
- Partials 972 975 +3
|
constantinius
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 4, 2025
Changes from here getsentry/sentry-python#5063
6 tasks
obostjancic
approved these changes
Nov 4, 2025
alexander-alderman-webb
approved these changes
Nov 4, 2025
constantinius
deleted the
constantinius/fix/integrations/mcp-transport
branch
constantinius
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 4, 2025
## DESCRIBE YOUR PR Correcting emitted values for `mcp.transport` attributes. Contributes to https://linear.app/getsentry/issue/TET-1354/mcp-transport-vs-network-transport Addressing changes from here getsentry/sentry-python#5063 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the wrong handling of
mcp.transport, it should be one of "http", "sse", or "stdio", not "pipe" or "tcp". These values are for thenetwork.transportattribute which was also introduced.Issues