Make PropagationContext hold baggage instead of dynamic_sampling_context #5156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
commented
Nov 26, 2025
| span_id=None, # type: Optional[str] | ||
| parent_span_id=None, # type: Optional[str] | ||
| parent_sampled=None, # type: Optional[bool] | ||
| dynamic_sampling_context=None, # type: Optional[Dict[str, str]] |
Member
Author
There was a problem hiding this comment.
I'm not removing the constructor parameter because that would be technically breaking but it does nothing now.
@sentrivana if we consider this class purely internal, I can also remove, wdyt?
Also, we never call this constructor with any arguments ourselves.
EDIT: Ignore, added backwards compat.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5156 +/- ##
==========================================
- Coverage 84.02% 83.98% -0.04%
==========================================
Files 180 180
Lines 18223 18226 +3
Branches 3233 3233
==========================================
- Hits 15311 15307 -4
- Misses 1922 1929 +7
Partials 990 990
|
sl0thentr0py
force-pushed
the
neel/prop-context-baggage-based
branch
from
7a0d9d6 to
8aba654
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
Maybe check cursor before merging @sl0thentr0py |
The tracing incoming headers implementation and the Transaction constructor take a `Baggage` object so this was incosistent with how I originally designed the baggage handling and created spaghetti loops between the two concepts.
sl0thentr0py
force-pushed
the
neel/prop-context-baggage-based
branch
from
8aba654 to
f0639ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Transaction.continue_from_headersand theTransactionconstructor take aBaggageobject so this was inconsistent with how I originally designed the baggage handling and created spaghetti loops between the two concepts.