feat(span-streaming): Add spans to telemetry pipeline, add span name and attributes (3) #5399
+86
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Span Streaming
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 11.79s All tests are passing successfully. ❌ Patch coverage is 21.57%. Project has 13716 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
sentrivana
commented
Jan 30, 2026
| self, telemetry: "Union[Log, Metric]" | ||
| self, telemetry: "Union[Log, Metric, StreamedSpan]" | ||
| ) -> None: | ||
| # TODO: turn Logs, Metrics into actual classes |
Contributor
Author
There was a problem hiding this comment.
Want to do this eventually, but it's a breaking change so it has to wait.
sentrivana
changed the title
sentrivana
commented
Jan 30, 2026
| span_id = trace_context.get("span_id") | ||
| if telemetry.get("span_id") is None and span_id: | ||
| telemetry["span_id"] = span_id | ||
| if not isinstance(telemetry, StreamedSpan): |
Contributor
Author
There was a problem hiding this comment.
The stuff for metrics and logs in this if should be moved elsewhere, but out of scope of this PR.
sentrivana
changed the title
alexander-alderman-webb
approved these changes
Jan 30, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| trace_id: "Optional[str]" = None, | ||
| ): | ||
| self.name: str = name | ||
| self._attributes: "Attributes" = attributes or {} |
There was a problem hiding this comment.
Initial attributes in StreamedSpan not formatted
Medium Severity
StreamedSpan.__init__ assigns attributes directly without calling format_attribute on each value, unlike the existing patterns in logger.py and metrics.py. This creates inconsistent behavior between using __init__(attributes=...) versus set_attribute()/set_attributes(), and violates the design principle stated in format_attribute's docstring: "We do this as soon as a user-provided attribute is set, to prevent spans, logs, metrics and similar from having live references to various objects." Unformatted attributes could retain live object references that mutate before serialization.
Contributor
Author
There was a problem hiding this comment.
This is actually correct, will fix
|
|
||
| def _capture_span(self, span: "StreamedSpan", scope: "Scope") -> None: | ||
| pass | ||
|
|
There was a problem hiding this comment.
Missing span_batcher in uWSGI thread support check
Low Severity
span_batcher spawns a background flusher thread via the inherited _ensure_thread method, but the condition checking whether to call check_uwsgi_thread_support() only includes self.log_batcher, not self.span_batcher. When running under uWSGI with threading disabled and only span streaming enabled (no logs, profiling, or monitor), users won't receive the warning about thread support issues, and spans will be silently dropped when thread creation fails.
Contributor
Author
There was a problem hiding this comment.
Will fix in follow up PR
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamedSpansince they're used in the pipelineChipping away at #5317 to transform it into reviewable and mergeable PRs.