ref(openai): Only handle streamed results when applicable#5553
Open
alexander-alderman-webb wants to merge 8 commits intowebb/openai/input-parameterfrom
Open
ref(openai): Only handle streamed results when applicable#5553alexander-alderman-webb wants to merge 8 commits intowebb/openai/input-parameterfrom
alexander-alderman-webb wants to merge 8 commits intowebb/openai/input-parameterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧Agents
Openai
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 31 passed | Total: 31 | Pass Rate: 100% | Execution Time: 12.13s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14420 uncovered lines. Files with missing lines (181)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 26.45% 27.50% +1.05%
==========================================
Files 189 189 —
Lines 19830 19891 +61
Branches 6428 6462 +34
==========================================
+ Hits 5246 5471 +225
- Misses 14584 14420 -164
- Partials 457 488 +31Generated by Codecov Action |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ericapisani
reviewed
Feb 26, 2026
Member
ericapisani
left a comment
ericapisani
left a comment
There was a problem hiding this comment.
Small cleanups but approving so as not to block
|
|
||
| def new_iterator() -> "Iterator[ChatCompletionChunk]": | ||
| nonlocal ttft | ||
| count_tokens_manually = True |
Member
There was a problem hiding this comment.
This doesn't appear to be needed in this iterator function - we never set it to false, so the conditional on line 644 will always run.
|
|
||
| async def new_iterator_async() -> "AsyncIterator[ChatCompletionChunk]": | ||
| nonlocal ttft | ||
| count_tokens_manually = True |
Member
There was a problem hiding this comment.
Same situation here as above - this is never set to False so the conditional further down on line 688 will always run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove iterator patches from shared output-handling code, and only apply them in the dedicated functions for patching streamed responses. Only keep code relevant to the Completions and Responses APIs in the respective iterator wrappers.
Add
stream=Trueto tests where a streamed response is returned fromopenaifunctions.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)