ref: Add no-op streaming span class (4)#5591
Merged
sentrivana merged 9 commits intomasterfrom Mar 5, 2026
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 78 passed | Total: 78 | Pass Rate: 100% | Execution Time: 946ms All tests are passing successfully. ❌ Patch coverage is 60.78%. Project has 13674 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sentrivana
force-pushed
the
ivana/span-first-3-add-active
branch
from
a655dca to
47e6211
Compare
sentrivana
force-pushed
the
ivana/span-first-4-add-noop-span
branch
from
c4641d6 to
80bfe5a
Compare
sentrivana
force-pushed
the
ivana/span-first-3-add-active
branch
from
47e6211 to
418572c
Compare
Base automatically changed from
ivana/span-first-3-add-active
to
ivana/span-first-2-tweak-span-interface
March 5, 2026 11:43
Base automatically changed from
ivana/span-first-2-tweak-span-interface
to
master
March 5, 2026 11:53
alexander-alderman-webb
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We'll use
NoOpStreamedSpans for spans that have a negative sampling decision or were filtered out viaignore_spans.They will get some minimal
__slots__and__init__in a future PR.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)