Skip to content

feat(asgi): Add option to disable suppressing chained exceptions#5714

Merged
alexander-alderman-webb merged 6 commits intomasterfrom
webb/asgi/suppress-chained-excpetions
Mar 20, 2026
Merged

feat(asgi): Add option to disable suppressing chained exceptions#5714
alexander-alderman-webb merged 6 commits intomasterfrom
webb/asgi/suppress-chained-excpetions

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Mar 20, 2026

Description

Add the experimental suppress_asgi_chained_exceptions option, defaulting to True when the option is not specified.

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner March 20, 2026 08:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (asgi) Add option to disable suppressing chained exceptions by alexander-alderman-webb in #5714
  • (logging) Separate ignore lists for events/breadcrumbs and sentry logs by sl0thentr0py in #5698

Bug Fixes 🐛

Anthropic

  • Set exception info on streaming span when applicable by alexander-alderman-webb in #5683
  • Patch AsyncStream.close() and AsyncMessageStream.close() to finish spans by alexander-alderman-webb in #5675
  • Patch Stream.close() and MessageStream.close() to finish spans by alexander-alderman-webb in #5674

Documentation 📚

  • Add note on AI PRs to CONTRIBUTING.md by sentrivana in #5696

Internal Changes 🔧

  • Add -latest alias for each integration test suite by sentrivana in #5706
  • Use date-based branch names for toxgen PRs by sentrivana in #5704
  • 🤖 Update test matrix with new releases (03/19) by github-actions in #5703
  • Add client report tests for span streaming by sentrivana in #5677

Other

  • Update CHANGELOG.md by sentrivana in #5685

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.16s

All tests are passing successfully.

❌ Patch coverage is 5.88%. Project has 14378 uncovered lines.

Files with missing lines (2)
File Patch % Lines
asgi.py 17.92% ⚠️ 142 Missing
consts.py 99.43% ⚠️ 2 Missing

Generated by Codecov Action

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft March 20, 2026 08:09
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review March 20, 2026 08:19
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@alexander-alderman-webb alexander-alderman-webb merged commit 48dc566 into master Mar 20, 2026
159 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/asgi/suppress-chained-excpetions branch March 20, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants