fix(huggingface_hub): stop setting transaction status on AI span errors#5864
Closed
NIK-TIGER-BILL wants to merge 1 commit intogetsentry:masterfrom
Closed
Conversation
AI integrations should not interfere with HTTP transactions. Replace set_span_errored() with direct span.set_status() to avoid propagating INTERNAL_ERROR to the containing HTTP transaction. Fixes getsentry#5793 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
stephanie-anderson
added
the
violating-contribution-guidelines
Contributor
|
This PR has been closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
stephanie-anderson
added
the
missing-maintainer-discussion
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Anthropic
Langchain
Pydantic Ai
Other
Bug Fixes 🐛Anthropic
Ci
Openai
Other
Documentation 📚
Internal Changes 🔧Anthropic
Docs
Langchain
Openai
Openai Agents
Other
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI integrations should not interfere with HTTP transactions.
_capture_exception()calledset_span_errored()which propagatedINTERNAL_ERRORto the containing HTTP transaction. Replace withget_current_span()+ directspan.set_status()that only affects the AI span.Changed files:
sentry_sdk/integrations/huggingface_hub.pytests/integrations/huggingface_hub/test_huggingface_hub.pyIssues
huggingface_hub: Stop setting transaction status #5793