fix(google-genai): Guard response extraction#5869
Merged
alexander-alderman-webb merged 1 commit intomasterfrom Mar 26, 2026
Merged
fix(google-genai): Guard response extraction#5869alexander-alderman-webb merged 1 commit intomasterfrom
alexander-alderman-webb merged 1 commit intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Langchain
Bug Fixes 🐛
Internal Changes 🔧Langchain
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 9.08s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14391 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 25.32% 30.23% +4.91%
==========================================
Files 189 189 —
Lines 20625 20627 +2
Branches 6738 6740 +2
==========================================
+ Hits 5223 6236 +1013
- Misses 15402 14391 -1011
- Partials 429 474 +45Generated by Codecov Action |
sentrivana
approved these changes
Mar 26, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both fields are declared to be optional:
https://github.com/googleapis/python-genai/blob/f4bcca45e0805c798ee86530e013a0c325d0af85/google/genai/types.py#L7485
https://github.com/googleapis/python-genai/blob/f4bcca45e0805c798ee86530e013a0c325d0af85/google/genai/types.py#L2145
Issues
Closes #5854
Reminders
tox -e linters.feat:,fix:,ref:,meta:)