fix(huggingface_hub): Stop setting transaction status when a child span fails#5952
Merged
alexander-alderman-webb merged 3 commits intogetsentry:masterfrom Apr 13, 2026
Conversation
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Huggingface Hub
Pydantic Ai
Other
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
alexander-alderman-webb
requested changes
Apr 10, 2026
Contributor
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Please set the span status by passing the exception tuple to span.__exit__() instead of adding logic to _capture_exception().
Otherwise LGTM!
Contributor
Author
|
Changes added! |
alexander-alderman-webb
approved these changes
Apr 13, 2026
af3a297
into
getsentry:master
152 of 153 checks passed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent the Hugging Face AI integration from changing root HTTP transaction status when API call fails
Keep error visibility on the integration span so failures are still captured and observable
Issues
huggingface_hub: Stop setting transaction status #5793Reminders
tox -e linters.feat:,fix:,ref:,meta:)