Skip to content

ref(celery): Remove unused NoOpMgr from utils#6078

Merged
sentrivana merged 1 commit intomasterfrom
ivana/celery-noop-mgr
Apr 15, 2026
Merged

ref(celery): Remove unused NoOpMgr from utils#6078
sentrivana merged 1 commit intomasterfrom
ivana/celery-noop-mgr

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented Apr 15, 2026

In the Celery integration, we use a custom NoOpMgr to make working with context managers a bit easier. It's defined in the file where we use it. There is another, completely unused copy in the utils.py of the Celery integration. Remove that one.

Note: Once we drop 3.6 support, we can replace the custom class with nullcontext from the standard library.

NoOpMgr was defined in both celery/__init__.py and celery/utils.py.
The utils copy was unused, so remove it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994

Bug Fixes 🐛

  • (google_genai) Redact binary data in inline_data and fix multi-part message extraction by ericapisani in #5977

Internal Changes 🔧

  • (celery) Remove unused NoOpMgr from utils by sentrivana in #6078
  • (pydantic-ai) Remove dead Model.request patch by alexander-alderman-webb in #5956
  • Set explicit base-branch for codecov action by ericapisani in #5992

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 9.22s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 15028 uncovered lines.


Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review April 15, 2026 10:11
@sentrivana sentrivana requested a review from a team as a code owner April 15, 2026 10:11
@sentrivana sentrivana changed the title ref(celery): Remove duplicate NoOpMgr from utils ref(celery): Remove unused NoOpMgr from utils Apr 15, 2026
@sentrivana sentrivana merged commit e23a8f1 into master Apr 15, 2026
162 checks passed
@sentrivana sentrivana deleted the ivana/celery-noop-mgr branch April 15, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants