test: Join thread in continuous profiler test#6125
Merged
alexander-alderman-webb merged 3 commits intomasterfrom Apr 22, 2026
Merged
test: Join thread in continuous profiler test#6125alexander-alderman-webb merged 3 commits intomasterfrom
alexander-alderman-webb merged 3 commits intomasterfrom
Conversation
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.93s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14757 uncovered lines. Generated by Codecov Action |
ericapisani
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flush the profiler's buffer after the first profile is collected, and suspend execution of main thread to wait for the profiler's buffer to flush before evaluating assertions.
According to the logs in the following failed run
https://github.com/getsentry/sentry-python/actions/runs/24769385099/job/72476526451
the test fails with the following stack trace:
The stack trace shows that profiles were not collected in the test transport by the time the assertion is executed.
The assertion runs before any manual calls to start and stop the profiler. The profiler is auto-activated and creates a profile for the transaction context manager.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)