fix(starlette/fastapi): Use inspect.iscoroutinefunction when Starlette does#6134
Open
alexander-alderman-webb wants to merge 1 commit intomasterfrom
Open
fix(starlette/fastapi): Use inspect.iscoroutinefunction when Starlette does#6134alexander-alderman-webb wants to merge 1 commit intomasterfrom
inspect.iscoroutinefunction when Starlette does#6134alexander-alderman-webb wants to merge 1 commit intomasterfrom
Conversation
alexander-alderman-webb
changed the title
inspect.iscoroutinefunction when Starlette does
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 10.11s All tests are passing successfully. ❌ Patch coverage is 40.00%. Project has 14787 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
ericapisani
approved these changes
Apr 24, 2026
|
|
||
|
|
||
| # Vendored: https://github.com/Kludex/starlette/blob/0a29b5ccdcbd1285c75c4fdb5d62ae1d244a21b0/starlette/_utils.py#L11-L17 | ||
| if sys.version_info >= (3, 13): # pragma: no cover |
There was a problem hiding this comment.
This will be true with Python version 4.0 and higher too, right? Using the _compat.py PY313 keeps its to Python 3.x.
Not sure if you care about that distinction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update existing code vendor.
Issues
Contributes to #6085
Reminders
tox -e linters.feat:,fix:,ref:,meta:)