fix(typing): Add @sentry_sdk.traces.trace overloads to fix typing#6236
Merged
sentrivana merged 1 commit intomasterfrom May 7, 2026
Merged
fix(typing): Add @sentry_sdk.traces.trace overloads to fix typing#6236sentrivana merged 1 commit intomasterfrom
@sentry_sdk.traces.trace overloads to fix typing#6236sentrivana merged 1 commit intomasterfrom
Conversation
Contributor
Codecov Results 📊✅ 7 passed | Total: 7 | Pass Rate: 100% | Execution Time: 2.00s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 17471 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 25.10% 20.26% -4.84%
==========================================
Files 190 190 —
Lines 21924 21911 -13
Branches 7378 7378 —
==========================================
+ Hits 5502 4440 -1062
- Misses 16422 17471 +1049
- Partials 471 328 -143Generated by Codecov Action |
vgrozdanic
approved these changes
May 7, 2026
alexander-alderman-webb
approved these changes
May 7, 2026
cla7aye15I4nd
pushed a commit
to cla7aye15I4nd/sentry-python
that referenced
this pull request
May 7, 2026
…etsentry#6236) Changing `sentry_sdk.trace` to `sentry_sdk.traces.trace` introduced a whole avalanche of [typing issues](https://github.com/getsentry/seer/actions/runs/25495762136/job/74814929830?pr=6291). Adding the overloads we have for the original `trace`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
sentry_sdk.tracetosentry_sdk.traces.traceintroduced a whole avalanche of typing issues.Adding the overloads we have for the original
trace.