feat(starlite): Support span streaming#6294
Merged
Merged
Conversation
sl0thentr0py
force-pushed
the
neel/span-first/starlite
branch
from
dc0e24b to
a5d33e6
Compare
Contributor
Codecov Results 📊✅ 59 passed | Total: 59 | Pass Rate: 100% | Execution Time: 25.30s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 20.00%. Project has 16258 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 27.27% 27.27% —%
==========================================
Files 190 190 —
Lines 22328 22353 +25
Branches 7576 7584 +8
==========================================
+ Hits 6088 6095 +7
- Misses 16240 16258 +18
- Partials 545 545 —Generated by Codecov Action |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/span-first/starlite
branch
from
a5d33e6 to
f0514b6
Compare
sentrivana
approved these changes
May 19, 2026
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
One attr name, looks good otherwise
| attributes={ | ||
| "sentry.op": op, | ||
| "sentry.origin": StarliteIntegration.origin, | ||
| "starlite.middleware_name": middleware_name, |
Contributor
There was a problem hiding this comment.
Suggested change
| "starlite.middleware_name": middleware_name, | |
| "middleware.name": middleware_name, |
https://getsentry.github.io/sentry-conventions/attributes/middleware/#middleware-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.