test: Respect context manager lifecycles in fake_record_sql_queries#6295
Merged
Conversation
alexander-alderman-webb
changed the title
fake_record_sql_queries()fake_record_sql_queries
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 42.98s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14858 uncovered lines. Generated by Codecov Action |
sentrivana
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the static trace lifecycle, set
span.start_timestampandspan.timestampimmediately after__enter__and__exit__are called, respectively.In the streaming trace lifecycle, set both
span._start_timestamandspan._end_timestampimmediately after__enter__is called, as the query source is added inside the context manager. Then resetspan._end_timestampimmediately before__exit__, as otherwise the span is not captured.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)