fix(asyncpg): Use Sentry span attribute name conventions#6306
Merged
Conversation
Update span attribute names to align with Sentry standards: - db.system → db.system.name - db.name → db.namespace Refactor _set_db_data to handle StreamedSpan (using set_attribute) and regular Span (using set_data) separately. The deprecated attributes are retained in the non-streamed path for backwards compatibility. Fixes PY-2424 Fixes #6299
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 42.56s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 15024 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
alexander-alderman-webb
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.system.nameanddb.namespaceinstead of deprecateddb.systemanddb.nameFixes PY-2424
Fixes #6299