fix(span-first): Set user.ip_address on all streamed spans#6434
Merged
Conversation
Use SPANDATA.USER_IP_ADDRESS constant and set it via sentry_sdk.get_isolation_scope().set_attribute() so the IP address is available on all spans, not just the server root span. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 67 passed | Total: 67 | Pass Rate: 100% | Execution Time: 5.87s All tests are passing successfully. ❌ Patch coverage is 41.18%. Project has 15191 uncovered lines. Files with missing lines (5)
Generated by Codecov Action |
Add test_user_ip_address_on_all_spans to wsgi, asgi, aiohttp, tornado, and sanic. Each test creates a child span and verifies user.ip_address is present on both server and child spans when send_default_pii=True. Fix tornado and sanic to set user.ip_address on the isolation scope before the handler runs, so child spans inherit the attribute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentrivana
changed the title
user.ip_address on isolation scope instead of span attributesuser.ip_address on all streamed spans
sentrivana
commented
May 29, 2026
| if client and should_send_default_pii(): | ||
| ip = _get_ip(asgi_scope) | ||
| attributes["client.address"] = ip | ||
| attributes["user.ip_address"] = ip |
Contributor
Author
There was a problem hiding this comment.
This was moved to asgi.py
alexander-alderman-webb
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user.ip_addressshould be attached to all spans as per https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#common-attribute-keys, not just segments. Set it on the isolation scope so that it gets applied to all spans active within it. Had to move setting the attr in a couple integrations so that it's set early enough for the child spans to also get it.