Skip to content

ci: Add new top-level orchestrator and upload coverage once#6446

Merged
sl0thentr0py merged 1 commit into
masterfrom
neel/chore/coverage
Jun 1, 2026
Merged

ci: Add new top-level orchestrator and upload coverage once#6446
sl0thentr0py merged 1 commit into
masterfrom
neel/chore/coverage

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented May 29, 2026

  • new test_orchestrator template that sits on top of all sub test workflows
  • each workflow uploads coverage artifacts that are merged in the final step
  • fix junit overwriting
  • one upload per workflow instead of per matrix entry

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner May 29, 2026 14:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Codecov Results 📊

88038 passed | ⏭️ 6009 skipped | Total: 94047 | Pass Rate: 93.61% | Execution Time: 293m 47s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2306 uncovered lines.


Generated by Codecov Action

@sl0thentr0py sl0thentr0py marked this pull request as draft May 29, 2026 14:52
@sl0thentr0py sl0thentr0py force-pushed the neel/chore/coverage branch 3 times, most recently from eb7a57e to c5cd7f6 Compare May 29, 2026 16:53
@sl0thentr0py sl0thentr0py changed the title ci(codecov): fix coverage ci: Add new top-level orchestrator and upload coverage once May 29, 2026
@sl0thentr0py sl0thentr0py force-pushed the neel/chore/coverage branch from c5cd7f6 to 554a568 Compare May 29, 2026 17:05
@sl0thentr0py sl0thentr0py marked this pull request as ready for review May 29, 2026 17:05
Comment thread .github/workflows/test.yml
Comment thread scripts/split_tox_gh_actions/templates/base.jinja
Comment thread .github/workflows/test-integrations-flags.yml
@sl0thentr0py sl0thentr0py force-pushed the neel/chore/coverage branch from 554a568 to 2e8afe3 Compare May 29, 2026 17:29
Comment thread scripts/split_tox_gh_actions/split_tox_gh_actions.py
@sentrivana
Copy link
Copy Markdown
Contributor

Nice 🚀

What's the equivalent of check-required now? Do we now still have one workflow per test group that collects the results of the whole group? Basically, what workflows do we need to make required now?

@sl0thentr0py
Copy link
Copy Markdown
Member Author

sl0thentr0py commented Jun 1, 2026

only the top level 'Test / All Tests Passed'

@sl0thentr0py sl0thentr0py force-pushed the neel/chore/coverage branch 2 times, most recently from aa0f34e to 252d8b7 Compare June 1, 2026 10:54
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 252d8b7. Configure here.

Comment thread scripts/split_tox_gh_actions/templates/test_group.jinja
Comment thread scripts/split_tox_gh_actions/split_tox_gh_actions.py
* new `test_orchestrator` template that sits on top of all sub test
  workflow
* fix junit overwriting
* one upload per workflow instead of per matrix entry
@sl0thentr0py sl0thentr0py force-pushed the neel/chore/coverage branch from 252d8b7 to 82716c9 Compare June 1, 2026 11:02
@sl0thentr0py sl0thentr0py merged commit 5cdbd39 into master Jun 1, 2026
268 of 270 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/chore/coverage branch June 1, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants