Skip to content

Android: multiple sourcemap uploads #255

@Zycon42

Description

@Zycon42

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

v8.6.0
5.4.2
pzrb2b@1.6.0 /Users/honza/Projects/pzrb2b
├── chroma-js@1.3.4
├── content-disposition@0.5.2
├── diacritics@1.3.0
├── hoist-non-react-statics@2.3.1
├── humps@2.0.1
├── intl@1.2.5
├── invariant@2.2.2
├── mime-types@2.1.17
├── mobile-center@0.9.0
├── mobile-center-analytics@0.9.0
├── mobile-center-crashes@0.9.0
├── moment@2.18.1
├── normalizr@3.2.3
├── prop-types@15.5.10
├── query-string@5.0.0
├── ramda@0.24.1
├── UNMET PEER DEPENDENCY react@16.0.0-alpha.12
├── react-intl@2.4.0
├── react-native@0.48.3
├── react-native-branch@2.0.0
├── react-native-config@0.6.1
├── react-native-device-info@0.11.0
├── react-native-fbsdk@0.6.1 invalid
├── react-native-fcm@8.0.1
├── react-native-fetch-blob@0.10.8
├── react-native-google-analytics-bridge@5.3.3
├── react-native-keyboard-aware-scroll-view@0.3.0
├── react-native-modal-dropdown@0.5.0
├── react-native-orientation@3.1.0
├── react-native-sentry@0.26.0
├── react-native-share@1.0.21
├── react-native-star-rating@1.0.8
├── react-native-svg@5.4.1
├── react-native-swiper@1.5.13
├── react-native-ux-cam@4.4.0
├── react-native-vector-icons@4.3.0
├── react-native-version-check@1.5.0
├── react-navigation@1.0.0-beta.13
├── react-redux@5.0.6
├── recompose@0.25.0
├── redux@3.7.2
├── redux-form@7.0.3
├── redux-logger@3.0.6
├── redux-observable@0.16.0
├── redux-persist@4.9.1
├── reselect@3.0.1
├── rxjs@5.4.3
└── validator@8.2.0

npm ERR! peer dep missing: react@^0.14.9 || ^15.0.0 || ^16.0.0, required by react-intl@2.4.0
npm ERR! peer dep missing: react@^0.14.0 || ^15.0.0, required by recompose@0.25.0
npm ERR! invalid: react-native-fbsdk@0.6.1 /Users/honza/Projects/pzrb2b/node_modules/react-native-fbsdk

Config:

Sentry.config('https://...@sentry.io/...').install()

I have following issue:

Using build types which change applicationId and versionName sourcemap are uploaded 4 times instead of only once

buildTypes {
        debug {
            versionNameSuffix "-dev"
        }

        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            signingConfig signingConfigs.release
        }

        releaseCI {
            initWith(buildTypes.release)
            signingConfig null
            versionNameSuffix "-ci"
            applicationIdSuffix ".beta"
        }

        releaseBeta {
            initWith(buildTypes.release)
            versionNameSuffix "-beta"
            applicationIdSuffix ".beta"
        }
    }

Steps to reproduce:

  • Add different build types that change versionName and applicationId

Actual result:

  • Source map is uploaded for each versionName/applicationId combination

Expected result:

  • Source map should be uploaded only once and for current build variant
  • If I run ./gradlew assembleReleaseBeta soucemap should be uploaded only for release com.example.app.beta-1.0.0-beta and not all other build variants defined in gradle

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions