Broken hermes crash reports on 1.3.0-1.3.3 (Android)

[lukebars]

OS:

• Windows
• MacOS
• Linux

Platform:

• iOS
• Android

SDK:

• @sentry/react-native
• react-native-sentry

SDK version: 2.0.0
react-native version: 0.61.1
@sentry/react-native version: 1.3.3

Init Code:

Sentry.init({
  dsn: 'https://...@sentry.io/...'
});

---

I have following issue:

I'm having issue that with 1.3.x when running android with hermes enabled, crash reports look to be broken on sentry dashboard.

Steps to reproduce:

• Build android release using ./gradlew assembleRelease with hermes engine enabled.
• Open the app.
• Produce error.
• See crash report on sentry.io

Actual result:

link
shared link

Expected result:

• Actual crash source map on sentry.io

My yarn.lock

 "@sentry/cli@^1.51.0":
  "@sentry/core@5.12.4", "@sentry/core@^5.12.0":
  "@sentry/hub@5.12.4":
  "@sentry/integrations@^5.12.0":
  "@sentry/minimal@5.12.4":
  "@sentry/react-native@^1.3.2":
  "@sentry/types@5.12.4", "@sentry/types@^5.12.0":
  "@sentry/utils@5.12.4", "@sentry/utils@^5.12.0":
  "@sentry/wizard@^1.1.1":

[marandaneto]

hey @lukebars thanks for raising this issue.
looking at your yarn file, it seems that you are using sentry 1.3.2: "@sentry/react-native@^1.3.2":
could you update to v1.3.3 and give it a try? thanks :)

[lukebars]

Sorry @marandaneto , that's an old yarn.lock, tried that on v.1.3.3 too before writing final issue, same result

[marandaneto]

Sorry @marandaneto , that's an old yarn.lock, tried that on v.1.3.3 too before writing final issue, same result

no worries, have you tried cleaning caches and doing it again?

eg:
./gradlew clean cleanBuildCache -> android dir.
run RN CLI npx react-native run-android --variant=release instead of ./gradlew assembleRelease

if still, would you mind updating RN to latest version v0.61.5 so we can isolate the problem?

Just to be sure it's not caching issues or something related to it, let us know, thanks.

[lukebars]

@marandaneto RN 0.61.5

./gradlew clean cleanBuildCache
npx react-native run-android --variant=release

url
shared url

Looks like it's the same. Also with 0.61.5 it doesn't build android until I remove the line from react-native link - apply from: "../../node_modules/@sentry/react-native/sentry.gradle" from build.gradle. After that it doesn't seem to upload the source maps.

"@sentry/browser@^5.12.1":
"@sentry/cli@^1.51.0":
"@sentry/core@5.12.5", "@sentry/core@^5.12.0":
"@sentry/hub@5.12.5":
"@sentry/integrations@^5.12.0":
"@sentry/minimal@5.12.5":
"@sentry/react-native@^1.3.3":
"@sentry/types@5.12.4", "@sentry/types@^5.12.0":
"@sentry/utils@5.12.5", "@sentry/utils@^5.12.0":
"@sentry/wizard@^1.1.1":

[marandaneto]

@lukebars thanks, if you comment/remove this line, for sure it's not gonna upload the source maps.

Let's start from the beginning, could you share the build error? that's new for us, thanks.

[lukebars]

@marandaneto happens only when upgraded to 0.61.5

> Task :app:transformClassesAndResourcesWithR8ForRelease FAILED
R8 is the new Android code shrinker. If you experience any issues, please file a bug at
https://issuetracker.google.com, using 'Shrinker (R8)' as component name. You can
disable R8 by updating gradle.properties with 'android.enableR8=false'.
Current version is: 1.4.94 (build 390954928f0db9c3b888a367f7f128ce3bbfb160 from go/r8bot (luci-r8-ci-archive-0-5g74)).

D8: Program type already present: io.sentry.BuildConfig

FAILURE: Build failed with an exception.

EDIT:

Looks like it was react-native link breaking it. Tried it with yarn sentry-wizard -i reactNative -p ios android and it built android successfully.

Although the crash report looks the same...
link

[marandaneto]

@marandaneto happens only when upgraded to 0.61.5

> Task :app:transformClassesAndResourcesWithR8ForRelease FAILED
R8 is the new Android code shrinker. If you experience any issues, please file a bug at
https://issuetracker.google.com, using 'Shrinker (R8)' as component name. You can
disable R8 by updating gradle.properties with 'android.enableR8=false'.
Current version is: 1.4.94 (build 390954928f0db9c3b888a367f7f128ce3bbfb160 from go/r8bot (luci-r8-ci-archive-0-5g74)).

D8: Program type already present: io.sentry.BuildConfig

FAILURE: Build failed with an exception.

EDIT:

Looks like it was react-native link what was breaking it. Tried it with yarn sentry-wizard -i reactNative -p ios android and it built android successfully.

Although the crash report looks the same...
link

The compile error should be because of Java 8 compatibility, see if you have this block in your app/build.gradle.

android {
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

[HazAT]

@lukebars Are you using CodePush or something similar by any chance?
The issue you linked looks really odd to a degree where it seems like your native code (java) and javascript code are out of sync.
So using old JS code with new native code.

If your issue looks like this

This stacktrace is the correct javascript stacktrace, but our JS SDK, for whatever reason was not able to pick this crash up.

The uploads of you sources maps and everything else looks correct, so that should be the issue.
It's really just this.

Are you able to reproduce this because it would be really helpful to figure under what constellation this kind of crash is happening?

[lukebars]

The compile error should be because of Java 8 compatibility, see if you have this block in your app/build.gradle.

android {
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

@marandaneto Yes, it's there, but it builds fine when unlinked (react-native unlink @sentry/react-native) and linked through the wizard command.

@lukebars Are you using CodePush or something similar by any chance?
The issue you linked looks really odd to a degree where it seems like your native code (java) and javascript code are out of sync.
So using old JS code with new native code.
This stacktrace is the correct javascript stacktrace, but our JS SDK, for whatever reason was not able to pick this crash up.

The uploads of you sources maps and everything else looks correct, so that should be the issue.
It's really just this.

Are you able to reproduce this because it would be really helpful to figure under what constellation this kind of crash is happening?

@HazAT Yes, codepush is enabled, but this build is straight compiled for testing new sentry, just out from the npx react-native run-android --variant=release oven. This kind of crash report happens all the time I'm tesing either writing an undefined function or throwing new Error

[HazAT]

@lukebars Something must be out of sync, running this on a clean react-native project works just fine.
Not really sure how to help you debug this.

[lukebars]

@HazAT @marandaneto it was deprecated sentry DSN that was causing it :)