misc(ci): Remove unused testflight node_modules cache #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 388.76 ms | 421.58 ms | 32.82 ms |
| 2af07d9+dirty | 389.92 ms | 426.21 ms | 36.29 ms |
| 09f796f+dirty | 391.98 ms | 451.30 ms | 59.32 ms |
| 8f69ce2+dirty | 411.39 ms | 456.56 ms | 45.17 ms |
| 03d7842+dirty | 382.43 ms | 426.12 ms | 43.69 ms |
| 5e47d60+dirty | 402.10 ms | 417.96 ms | 15.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 2af07d9+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 09f796f+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 8f69ce2+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 03d7842+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 5e47d60+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 1244.29 ms | 1243.61 ms | -0.68 ms |
| 03d7842+dirty | 1238.23 ms | 1241.08 ms | 2.85 ms |
| 8f69ce2+dirty | 1225.96 ms | 1235.49 ms | 9.53 ms |
| 5e47d60+dirty | 1233.71 ms | 1233.22 ms | -0.49 ms |
| 09f796f+dirty | 1229.16 ms | 1214.74 ms | -14.42 ms |
| 2af07d9+dirty | 1237.73 ms | 1234.75 ms | -2.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 2.92 MiB | 3.64 MiB | 739.85 KiB |
| 03d7842+dirty | 2.92 MiB | 3.64 MiB | 739.81 KiB |
| 8f69ce2+dirty | 2.92 MiB | 3.64 MiB | 739.81 KiB |
| 5e47d60+dirty | 2.92 MiB | 3.64 MiB | 743.91 KiB |
| 09f796f+dirty | 2.92 MiB | 3.64 MiB | 739.84 KiB |
| 2af07d9+dirty | 2.92 MiB | 3.64 MiB | 739.88 KiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 1231.18 ms | 1236.79 ms | 5.61 ms |
| 03d7842+dirty | 1222.02 ms | 1232.84 ms | 10.82 ms |
| 8f69ce2+dirty | 1211.06 ms | 1214.98 ms | 3.92 ms |
| 5e47d60+dirty | 1223.51 ms | 1222.85 ms | -0.66 ms |
| 09f796f+dirty | 1222.62 ms | 1224.69 ms | 2.07 ms |
| 2af07d9+dirty | 1230.71 ms | 1232.44 ms | 1.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f56d09+dirty | 2.36 MiB | 3.08 MiB | 733.60 KiB |
| 03d7842+dirty | 2.36 MiB | 3.08 MiB | 733.56 KiB |
| 8f69ce2+dirty | 2.36 MiB | 3.08 MiB | 733.55 KiB |
| 5e47d60+dirty | 2.36 MiB | 3.09 MiB | 742.34 KiB |
| 09f796f+dirty | 2.36 MiB | 3.08 MiB | 733.51 KiB |
| 2af07d9+dirty | 2.36 MiB | 3.08 MiB | 733.57 KiB |
antonis
approved these changes
Oct 15, 2024
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM! Thank you for fixing this @krystofwoldrich 🙇
antonis
added a commit
that referenced
this pull request
Oct 16, 2024
* Updates RN to 0.75.4 in the sample app and E2E test * Removes Flipper from iOS * Fixes lint issue (see facebook/react-native#33955) * enable corepack in testflight dependencies step * Sets the newArchEnabled=false for legacy builds * enable corepack in testflight build step * Enable corepack in a separate step * Removes corepack step * Updates OnLoad.cpp and CMakeList.txt to match the RN version samples * Enable corepack and remove cache check * Reverts CMakeLists.txt change * Update yarn cache in testflight build * Updates PrivacyInfo * misc(ci): Remove unused testflight node_modules cache (#4178) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog