Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Oct 31, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Renames test cases due to deprecation of ExperimentalViewRenderer as a follow up to #5322

💡 Motivation and Context

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.15 ms 369.51 ms 26.36 ms
Size 17.75 MiB 19.75 MiB 2.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
93137d1+dirty 400.15 ms 424.74 ms 24.59 ms
46bd012 387.09 ms 404.47 ms 17.38 ms
11ded16+dirty 317.29 ms 329.15 ms 11.86 ms
1853710 555.47 ms 556.59 ms 1.12 ms
88890fe+dirty 350.94 ms 365.74 ms 14.80 ms
a0b15d6 423.06 ms 437.77 ms 14.71 ms
f234eb4+dirty 407.62 ms 429.64 ms 22.02 ms
785ffb1 471.92 ms 460.96 ms -10.96 ms
a2bb688+dirty 409.65 ms 410.45 ms 0.80 ms
8a4ce6f 422.88 ms 408.33 ms -14.55 ms

App size

Revision Plain With Sentry Diff
93137d1+dirty 17.75 MiB 19.70 MiB 1.95 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB
11ded16+dirty 17.75 MiB 19.75 MiB 2.00 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB
88890fe+dirty 17.75 MiB 19.71 MiB 1.96 MiB
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
f234eb4+dirty 17.75 MiB 19.74 MiB 1.99 MiB
785ffb1 17.75 MiB 20.15 MiB 2.41 MiB
a2bb688+dirty 17.75 MiB 19.70 MiB 1.95 MiB
8a4ce6f 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 297.16 ms 318.19 ms 21.03 ms
Size 7.15 MiB 8.46 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
276d348+dirty 356.30 ms 405.27 ms 48.97 ms
170d5ea+dirty 348.79 ms 406.94 ms 58.15 ms
1bea095+dirty 416.54 ms 506.00 ms 89.46 ms
46da307+dirty 356.62 ms 415.02 ms 58.40 ms
2adbd1e+dirty 366.13 ms 419.49 ms 53.36 ms
a02e30b+dirty 346.13 ms 381.76 ms 35.62 ms
90afdd3+dirty 367.79 ms 404.84 ms 37.05 ms
1e7a472+dirty 319.58 ms 372.29 ms 52.71 ms
d861c16+dirty 334.54 ms 339.27 ms 4.72 ms

App size

Revision Plain With Sentry Diff
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
276d348+dirty 7.15 MiB 8.42 MiB 1.26 MiB
170d5ea+dirty 7.15 MiB 8.42 MiB 1.27 MiB
1bea095+dirty 7.15 MiB 8.43 MiB 1.28 MiB
46da307+dirty 7.15 MiB 8.41 MiB 1.26 MiB
2adbd1e+dirty 7.15 MiB 8.43 MiB 1.28 MiB
a02e30b+dirty 7.15 MiB 8.42 MiB 1.27 MiB
90afdd3+dirty 7.15 MiB 8.43 MiB 1.28 MiB
1e7a472+dirty 7.15 MiB 8.43 MiB 1.28 MiB
d861c16+dirty 7.15 MiB 8.43 MiB 1.28 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.98 ms 1229.60 ms 6.63 ms
Size 2.63 MiB 4.01 MiB 1.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
23080e5+dirty 1216.02 ms 1224.94 ms 8.91 ms
3099014+dirty 1226.75 ms 1236.56 ms 9.81 ms
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
6a70a7e+dirty 1225.82 ms 1230.79 ms 4.98 ms
59f3a84+dirty 1232.56 ms 1238.12 ms 5.56 ms
90afdd3+dirty 1233.90 ms 1240.90 ms 7.00 ms
46da307+dirty 1217.08 ms 1224.16 ms 7.08 ms
af9331b+dirty 1233.61 ms 1230.50 ms -3.11 ms
bfe454a+dirty 1235.33 ms 1243.12 ms 7.79 ms
20d5eaa+dirty 1231.12 ms 1226.00 ms -5.12 ms

App size

Revision Plain With Sentry Diff
23080e5+dirty 2.63 MiB 3.91 MiB 1.28 MiB
3099014+dirty 2.63 MiB 3.98 MiB 1.35 MiB
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
6a70a7e+dirty 2.63 MiB 3.98 MiB 1.34 MiB
59f3a84+dirty 2.63 MiB 3.99 MiB 1.36 MiB
90afdd3+dirty 2.63 MiB 3.99 MiB 1.35 MiB
46da307+dirty 2.63 MiB 3.87 MiB 1.24 MiB
af9331b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
bfe454a+dirty 2.63 MiB 3.98 MiB 1.34 MiB
20d5eaa+dirty 2.63 MiB 3.81 MiB 1.18 MiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.27 ms 1227.49 ms -0.78 ms
Size 3.19 MiB 4.58 MiB 1.39 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
23080e5+dirty 1221.39 ms 1222.08 ms 0.70 ms
3099014+dirty 1234.04 ms 1243.22 ms 9.18 ms
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
6a70a7e+dirty 1231.40 ms 1239.49 ms 8.09 ms
59f3a84+dirty 1205.09 ms 1213.31 ms 8.23 ms
90afdd3+dirty 1216.17 ms 1225.55 ms 9.38 ms
46da307+dirty 1213.45 ms 1207.96 ms -5.49 ms
af9331b+dirty 1230.08 ms 1233.24 ms 3.16 ms
bfe454a+dirty 1231.82 ms 1239.98 ms 8.16 ms
20d5eaa+dirty 1224.67 ms 1223.16 ms -1.51 ms

App size

Revision Plain With Sentry Diff
23080e5+dirty 3.19 MiB 4.48 MiB 1.29 MiB
3099014+dirty 3.19 MiB 4.55 MiB 1.36 MiB
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
6a70a7e+dirty 3.19 MiB 4.54 MiB 1.36 MiB
59f3a84+dirty 3.19 MiB 4.56 MiB 1.37 MiB
90afdd3+dirty 3.19 MiB 4.55 MiB 1.37 MiB
46da307+dirty 3.19 MiB 4.44 MiB 1.25 MiB
af9331b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
bfe454a+dirty 3.19 MiB 4.54 MiB 1.36 MiB
20d5eaa+dirty 3.19 MiB 4.38 MiB 1.19 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit aa28c7f into main Oct 31, 2025
101 of 103 checks passed
@antonis antonis deleted the antonis/rename-ViewRendererV2-tests branch October 31, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants