Skip to content

Unnecessary API path modification #255

@zepheiryan

Description

@zepheiryan

Discussed initially with @nateberkopec inline in 9a0d5ea, there's a line that takes the earlier, correctly parsed DSN URI and then removes all instances of the string /sentry from it with a .gsub to generate an incorrect API path for anybody whose Sentry instance runs with a prefix including that string (I do, and I have to imagine it's a common choice). It doesn't seem to serve any purpose, and the test case that accompanies the change doesn't seem to follow the published DSN parsing to API path spec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions