Add user configurable sanitizer fields #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/raven/client.rb
Outdated
Contributor
There was a problem hiding this comment.
:( passing the sanitize fields config here isn't great, since it's only required by a single, specific processor. I think it's possible to keep the original interface here.
Author
There was a problem hiding this comment.
oops, yeah much cleaner accessing the client directly 👍
Contributor
|
❤️ except for the one parameter concern there - we should be able to access the configuration object without adding that parameter (since we're passing the entire client along when we initialize the processor). |
Contributor
|
This will allow people to pass in Rails.config.filter_parameters! (#39) |
jamescway
force-pushed
the
add-sanitize-fields
branch
from
6041f5c to
dc1fc4d
Compare
Contributor
|
Boom! Love it. Thanks! |
nateberkopec
added a commit
that referenced
this pull request
Nov 8, 2014
Add user configurable sanitizer fields. Close #39.
Author
|
thank u sir 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify some additional fields to sanitize. Replaces the values with the string mask (********)