Don't mutate configuration tags hash on event creation #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often include a non-overlapping set of tags when reporting different types of events. It turns out that Event.initialize was mutating the Configuration object's state instead of creating a local copy.
There was a problem hiding this comment.
What do you think about solving this for all args? It doesn't seem correct for Event.initialize() to change its params at all. Eg @user, @extra, etc.
Author
There was a problem hiding this comment.
I think the ownership there is a bit more clear, but not opposed.
nateberkopec
added a commit
that referenced
this pull request
Nov 18, 2014
Don't mutate configuration tags hash on event creation
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often include a non-overlapping set of tags when reporting
different types of events. It turns out that Event.initialize
was mutating the Configuration object's state instead of creating
a local copy.