fix(rails): fix logging of cached queries with binds #2789
Merged
+43
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
2785-activerecordsubscriber-fails-to-log-most-queries-on-rails-803-everywhere-except-jruby
branch
from
3d2857a to
afd6b90
Compare
solnic
commented
Nov 24, 2025
| binds = event.payload[:binds] | ||
|
|
||
| if Sentry.configuration.send_default_pii && binds&.any? | ||
| if Sentry.configuration.send_default_pii && (binds && !binds.empty?) |
Collaborator
Author
There was a problem hiding this comment.
More verbose but actually faster
| # When a query is cached, binds are a callable, | ||
| # and under JRuby they're always a callable. | ||
| if binds.respond_to?(:call) | ||
| binds.call |
Member
There was a problem hiding this comment.
does that mean in the cached case, we will incur extra overhead to fetch the binds?
Collaborator
Author
There was a problem hiding this comment.
@sl0thentr0py a bit, but it's hard to tell what the impact is w/o measuring it. Want me to check?
sl0thentr0py
approved these changes
Nov 25, 2025
solnic
deleted the
2785-activerecordsubscriber-fails-to-log-most-queries-on-rails-803-everywhere-except-jruby
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2785