Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry-ruby/lib/sentry/scope.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def dup
copy.session = session.deep_dup
copy.propagation_context = propagation_context.deep_dup
copy.attachments = attachments.dup
copy.event_processors = event_processors.dup
copy
end

Expand Down
17 changes: 17 additions & 0 deletions sentry-ruby/spec/sentry/hub_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,23 @@
expect(outter_event.tags).to eq({ level: 1 })
end

it "doesn't leak event processors to the outer scope" do
processor_calls = 0

2.times do
subject.with_scope do |scope|
scope.add_event_processor do |event, _hint|
processor_calls += 1
event
end

subject.capture_message("test")
end
end

expect(processor_calls).to eq(2)
end

it "doesn't leak data mutation" do
inner_event = nil
scope.set_tags({ level: 1 })
Expand Down
10 changes: 10 additions & 0 deletions sentry-ruby/spec/sentry/scope_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@
expect(subject.span).to eq(nil)
end

it "copies event_processors so mutations don't affect the original" do
subject.add_event_processor { |event, _hint| event }
copy = subject.dup

copy.add_event_processor { |event, _hint| event }

expect(subject.event_processors.length).to eq(1)
expect(copy.event_processors.length).to eq(2)
end

it "deep-copies span as well" do
perform_basic_setup

Expand Down
Loading