Add support for ActiveJob. #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 We should probably only carry ActiveJob integration in the base gem, and spin out Sidekiq integration to a separate gem. |
Contributor
Author
|
@nateberkopec one alternative that I can think of is make it disabled by default - the deprecation cycle/upgrade path could be simpler. |
Contributor
Author
|
@nateberkopec sorry for the huge delay on this one. I've tested this branch against a fresh Rails app using Sidekiq and added a safeguard to the |
nateberkopec
added a commit
that referenced
this pull request
Jul 14, 2015
Add support for ActiveJob.
Member
|
I've reverted this for now until we sort out #368. It might be that as a quick workaround we remove the clause to prevent the duplicate and sort out those problems later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some of the initial code to add support for Active Job subclasses regardless of the queue backend that is being used - Raven currently supports Sidekiq on it's own but would be nice to have a broader support for other backends like SuckerPunch (the one I'm using), Resque, DelayedJob, etc.
I couldn't find any tests for the Sidekiq support to use as a base, but I'm take this to a spin in our app to see how it goes. Also, I fear that loading both the ActiveJob support + Sidekiq might generate duplicate reports since both integrations would be executed together, but this is something that I need to test it out to be sure about it.