Don't check catch_debugged_exceptions setting before user has set it
#458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Whoops - yup! |
nateberkopec
added a commit
that referenced
this pull request
Feb 13, 2016
…setting Don't check `catch_debugged_exceptions` setting before user has set it
Contributor
|
😩 thanks for fixing this, and apologies for breaking it in the first place. I'm trying to write a spec to cover this behaviour now, although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a side effect of https://github.com/getsentry/raven-ruby/pull/450 was to remove the usefulness of the
catch_debugged_exceptionssetting. Checking this setting obviously need to be done after it's set.