Check catch_debugged_exceptions option at runtime #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
force-pushed
the
check_catch_debugged_exceptions_at_runtime
branch
2 times, most recently
from
16b8af0 to
bf5e881
Compare
Instead of adding the hook to report debugged exceptions based on the value of the configuration option while Rails is initialising, we can always add the hook, but have it check the option at runtime. This is more in line with how other configuration options are used, and means that the option can be set or changed at any time. This also lets us write tests that exercise this behaviour, since the logic is no longer tied to the Rails initialisation process which can only happen once during the test suite.
Contributor
|
Punting on this for 0.15.6. It feels really weird that we inject our middleware no matter what here. |
Contributor
|
Yeah, I'm not comfortable with this. I think the long term fix for making this testable is probably related to #462, because working with this singleton Raven configuration in our tests is making us bend over backwards. We should fix how we deal with this in the tests rather than the code. |
Contributor
Author
|
👍 |
Contributor
Author
|
Thinking about this some more, testing this code is difficult because Rails is a singleton, not Raven - addressing #462 won't make it any easier. Interestingly, Rails had the same choice to make with |
alexford
pushed a commit
to alexford/raven-ruby
that referenced
this pull request
Jan 1, 2017
…follow_up [test] Simplified httpclient_test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding the hook to report debugged exceptions based on the value of the configuration option while Rails is initialising, we can always add the hook, but have it check the option at runtime. This is more in line with how other configuration options are used, and means that the option can be set or changed at any time, which would have prevented #458.
This also lets us write tests that exercise this behaviour, since the logic is no longer tied to the Rails initialisation process, which can only happen once during the test suite.